Avoid duplicate calculation of number of float variables #1067
+3
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be interested to look at this, especially because CI fails with: Error: ForNetConTest is a different MOD file than used by NEURON!
Error : NEURON and CoreNEURON must use same mod files for compatibility, 1 different mod file(s) found. Re-compile special and special-core!
Fatal Python error: Aborted |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
- Coverage 69.96% 69.94% -0.02%
==========================================
Files 188 188
Lines 25664 25648 -16
==========================================
- Hits 17956 17940 -16
Misses 7708 7708
☔ View full report in Codecov by Sentry. |
iomaganaris
force-pushed
the
magkanar/fix_var_counting
branch
from
4038fae
to
de63f6d
Compare
iomaganaris
changed the title
|
If the CI passes this should now be ready to merge |
|
You could implement one in terms of the other, then the symmetry between int and float variable remains; but the code duplication is gone. |
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #151687 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
@1uc ready to merge? Do you want to give a final look? |
1uc
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 things:
codegen_float_variablesvector sizeintvariables usingSTL